Initial update to circleci v2 config.

[b4handjr]

Should fix #2609

This new config uses the docker-compose configuration to run both the unit tests and a new suite of integration tests. The integration tests can be found here.

The unit tests and integration tests run per commit. These also run on each master/release branch build as well as docker deploys.

I think I have most of the old config added but, of course, this can be changed as needed.

[arikfr]

Thanks! This is greatly helpful.

See my comments :)

[arikfr]

We were using Node v6.9 because that's the latest that was available in the old platform. Now I assume we can use something newer?

[b4handjr]

I didn't specify an exact version in error, but It defaults to 6.14 if I remember correctly. You can view some builds/logs here: https://circleci.com/gh/mozilla/redash/tree/update-circleci

[jezdez]

@arikfr There are a lot more modern npm versions on https://hub.docker.com/r/circleci/node/tags/ but I would recommend not doing an update at the same time as this pull request to remove the chance for conflicting issues.

[b4handjr]

@jezdez I don't think 6.9 is available as a docker image though. Unless you are talking about doing a major update to the code-base, outside of this PR.

[arikfr]

Let's update to circleci/node:8, which is the latest LTS and the version I've been working with for along time now, so doubt there will be any issues.

[arikfr]

This feels brittle... did you try the following:

1. docker-compose up -d --no-start -> this will create all the necessary containers.
2. docker-compose start postgres -> this will return when Postgres is running.
3. Now you can proceed to creating the database and running the tests.

?

[b4handjr]

That's pretty slick, I should give that a go since --rm will run the containers anyway.

[arikfr]

Don't we need to define the tar ball file as an artifact?

[b4handjr]

So this where I need some clarification. Do we just want the artifact as a circleci artifact? Or does it need to be something specific. Circleci 2.0 doesn't have much on the old tarball command, just stating that it was an artifact.

[b4handjr]

Looking at current master builds on circle, there is an artifact with a tar.gz extension. Is this made with the command bin/pack ?

[jezdez]

@jrbenny35 Yep, bin/pack basically puts everything in the repo clone into a tarball (except a few things like git history and node_modules etc).

[arikfr]

Yes, it just needs to be available as a CircleCI artifact.

[jezdez]

@arikfr Just to clarify, are you okay with this PR running the UI tests that are developed over in https://github.com/mozilla/redash-ui-tests here?

[b4handjr]

Just added some updates. Let me know if there is anything still missing.

[hackebrot]

Hey @arikfr! 👋

Can you please give this another look and see if we can merge this to master?

Thank you! 🙇

[b4handjr]

Any updates on this?

[jezdez]

@jrbenny35 I've talked with @arikfr about this and we settled on this:

• If there is an option to configure Circle CI to optionally run the UI tests (e.g. by clicking a button) when needed, then we should do that.
• If there isn't an option we agreed that it's too early to use the UI tests in this repo and would like to ask you to remove them for now so we can merge this without it.

[b4handjr]

If there is an option to configure Circle CI to optionally run the UI tests (e.g. by clicking a button) when needed, then we should do that.

What is the idea behind this?

[jezdez]

Am 24.08.2018 um 16:18 schrieb Benjamin Forehand Jr ***@***.***>: If there is an option to configure Circle CI to optionally run the UI tests (e.g. by clicking a button) when needed, then we should do that. What is the idea behind this?

Basically to make sure that the runtime of the tests isn’t increased and minor changes don’t trigger the UI tests by default. Instead when big features land or UI components are changed we could trigger the UI tests on demand from the Circle CI user interface.

[b4handjr]

Basically to make sure that the runtime of the tests isn’t increased and minor changes don’t trigger the UI tests by default. Instead when big features land or UI components are changed we could trigger the UI tests on demand from the Circle CI user interface.

What about a branch or a commit string? I don't think there is a button to run tests on circle.

[jezdez]

There is also the ability to approve specific jobs of a workflow on Circle CI

[b4handjr]

I don't know if this change will work but from my research circleci step halt found here allows the job to be cancelled without returning a failure code.

The string I used is !run-ui-tests. Not sure if it will work until merging though.

[arikfr]

Thanks @jrbenny35 for your help wit this! I merged this now and will follow up on any further changes (if needed) myself as it will be easier having access to CircleCI's console.