Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Circle CI v2.0 #2609

Closed
hackebrot opened this issue Jun 20, 2018 · 1 comment · Fixed by #2672
Closed

Migrate to Circle CI v2.0 #2609

hackebrot opened this issue Jun 20, 2018 · 1 comment · Fixed by #2672

Comments

@hackebrot
Copy link
Member

Hi folks! 👋

Circle CI is dropping support for version 1.0 builds end of August, so I'm suggesting to migrate to the new build config format soon. See note in the Circle CI documentation here ⚠️

They also provide documentation on how to do the migration.

Would you be OK with a PR to also update the CI configuration to use the same mechanism for running the tests as for running the tests locally? Currently we install dependencies manually and run pytest directly as opposed to using docker-compose and the tests entrypoint

$ docker-compose run --rm server tests
@arikfr
Copy link
Member

arikfr commented Jun 20, 2018

Would you be OK with a PR to also update the CI configuration to use the same mechanism for running the tests as for running the tests locally?

Sure! This will be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants