Core: fixed typing for conditional expression #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8231 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 1158 1158
Lines 100089 100093 +4
=======================================
+ Hits 94629 94633 +4
Misses 5460 5460
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
changed the title
bblommers
approved these changes
Oct 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With it's latest release,
mypyhas improved it's capabilities to Inferring Unions for Conditional Expressions. This created a new issues withmypyand tests failing at the linting step.Changes
var = None) conflict with inference in conditional expression (var = "string" if cond() else None) resulting inexpression has type "Union[Any, str]", variable has type "None"error.