WIP feat: Changed resource config to allow custom values #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For fixing error with labels for nvidia gpus/tpus being not propagated/transmitted to environments properly
|
Not ready yet, to be added: |
marrrcin
reviewed
Nov 22, 2022
kedro_kubeflow/config.py
Outdated
| default.update(value) | ||
| # else: | ||
| # # throw some error? | ||
| # logger.error(value, "Unknown type") |
There was a problem hiding this comment.
Would be nice to actually throw some error in the validator here
marrrcin
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For fixing error with labels for nvidia gpus/tpus being not propagated/transmitted to environments properly
Resolves #199
PR Checklist