Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource nvidia.com/gpu Not Handled by ResourceConfig #199

Open
cupdike opened this issue Nov 10, 2022 · 3 comments · Fixed by #202
Open

Resource nvidia.com/gpu Not Handled by ResourceConfig #199

cupdike opened this issue Nov 10, 2022 · 3 comments · Fixed by #202
Labels
bug Something isn't working

Comments

@cupdike
Copy link

cupdike commented Nov 10, 2022

In kedro-kubeflow 0.7.3, if gpu's are assigned in kubeflow.yaml using an nvidia.com/gpu element, they are not applied to the node as expected in the generated pipeline since they are not handled by the respective ResourceConfig class in config.py:
https://github.com/getindata/kedro-kubeflow/blob/0.7.3/kedro_kubeflow/config.py#L181

@marrrcin marrrcin added the bug Something isn't working label Nov 14, 2022
@marrrcin
Copy link
Contributor

Thanks for reporting this @cupdike , we will fix it soon!

@Lasica
Copy link
Contributor

Lasica commented Nov 23, 2022

Sorry didn't mean to close it. I've added the support for custom labels in the resources. It's present in the current develop branch. Could you maybe try if this works for you and report back?

@marrrcin
Copy link
Contributor

@cupdike have you been able to test out the fix provided by @Lasica ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants