Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker file pip packages upgrade and dependencies addition - jupyterlab streaming #61

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Docker file pip packages upgrade and dependencies addition - jupyterlab streaming #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33e242
streaming docker file fix
jomrdjan Dec 5, 2023
1d9c2a9
Bring back requirements.txt for pip install
jomrdjan Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions jupyterlab-streaming/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,17 @@ RUN code-server --install-extension ms-python.python${VSCODE_PYTHON}
COPY resources/vsc/settings.json /root/.local/share/code-server/Machine/
COPY resources/vsc/.bashrc root/

COPY requirements.txt .
RUN pip install pip --upgrade \
&& pip install --no-cache -r requirements.txt \
&& pip cache purge \
&& rm requirements.txt
RUN pip install --no-cache-dir \
jupyterlab==$(conda list -f jupyterlab --json | grep -oP '(?<=\"version\": \")[^\"]*') \
jupyterlab-git \
jupyterlab-lsp \
jupyter-server-proxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you decided to keep it in a Docker file instead of a requirements file? I would prefer requirements I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-pekala I've uploaded back requirements and changed Dockerfile


RUN pip install --no-cache-dir streamingcli==2.0.3
RUN pip install --no-cache-dir jupyter-packaging==0.12.2
RUN pip install --no-cache-dir streaming-jupyter-integrations==0.14.0 && pip cache purge
RUN pip install --no-cache-dir apache-flink==1.16.1
RUN pip install typing-extensions --upgrade

COPY --from=MAVEN_BUILD /var/tmp/flink-deps/ $PYFLINK_LIB_DIR
COPY resources/jupyter/jupyter_notebook_config.py /etc/jupyter/jupyter_notebook_config.py
Expand Down
24 changes: 24 additions & 0 deletions jupyterlab-streaming/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,30 @@
<artifactId>flink-http-connector</artifactId>
<version>${http-connector.version}</version>
</dependency>

<dependency>
<groupId>com.getindata</groupId>
<artifactId>flink-ververica-catalog-proxy-1.16</artifactId>
<version>0.2.0</version>
</dependency>

<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-avro</artifactId>
<version>${flink.version}</version>
</dependency>

<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-avro-confluent-registry</artifactId>
<version>${flink.version}</version>
</dependency>

<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
<version>42.2.2</version>
</dependency>
</dependencies>

<build>
Expand Down
7 changes: 0 additions & 7 deletions jupyterlab-streaming/requirements.txt
View file
Open in desktop

This file was deleted.

Loading