Docker file pip packages upgrade and dependencies addition - jupyterlab streaming #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update dependencies for pip packages update maven pom dependencies
p-pekala
reviewed
Dec 6, 2023
| jupyterlab==$(conda list -f jupyterlab --json | grep -oP '(?<=\"version\": \")[^\"]*') \ | ||
| jupyterlab-git \ | ||
| jupyterlab-lsp \ | ||
| jupyter-server-proxy |
There was a problem hiding this comment.
why have you decided to keep it in a Docker file instead of a requirements file? I would prefer requirements I think.
There was a problem hiding this comment.
@p-pekala I've uploaded back requirements and changed Dockerfile
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions of pip packages (packages from master branch are blocking docker image build, because of supporting outdated version of date-utils pip package).
Update maven pom dependencies - additional dependencies have been added
Im able to build image locally after changes performed:
