Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Wallet might block contract setup #2453

Closed
bonomat opened this issue Jul 19, 2022 · 4 comments
Closed

Wallet might block contract setup #2453

bonomat opened this issue Jul 19, 2022 · 4 comments

Comments

@bonomat
Copy link
Collaborator

bonomat commented Jul 19, 2022 •
edited
Loading

I have the suspicion that our wallet actor might be the source of blocked/delayed contract setup:

The wallet actor syncs synchronously, meaning, it is blocked for the time it is syncing. This can be a significant amount of time (>40 seconds). In the meantime, the actor is not able to handle other messages.
However, in the contract setup we need to ask this actor for information
@bonomat bonomat mentioned this issue Jul 19, 2022
Closed
@bonomat
Copy link
Collaborator Author

bonomat commented Jul 19, 2022

This is related: #947

@bonomat
Copy link
Collaborator Author

bonomat commented Jul 19, 2022

I can confirm this:

  • manually hit wallet sync on maker
  • open position on taker

see that nothing is happening until the maker sync is done.

@Restioson
Copy link
Collaborator

We are blocking the tokio from the Wallet actor, which I think is probably one of the issues

This was referenced Jul 19, 2022
Open
Merged
bors bot added a commit that referenced this issue Jul 19, 2022
@bors @Restioson
Merge #2469
b58d72c 
2469: Spawn wallet actor as a blocking task r=klochowicz a=Restioson

This is solution 2 to #2453. It spawns the wallet actor as a blocking task. I am not 100% sure if this will correctly make the thread park when nothing is being sent to the wallet actor.

Co-authored-by: Restioson <[email protected]>
@bonomat
Copy link
Collaborator Author

bonomat commented Jul 25, 2022

let's hope that #2469 made it better

@bonomat bonomat closed this as completed Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bonomat @Restioson