Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Exchange signed lock transaction took 30 seconds #2413

Closed
bonomat opened this issue Jul 14, 2022 · 8 comments
Closed

Exchange signed lock transaction took 30 seconds #2413

bonomat opened this issue Jul 14, 2022 · 8 comments

Comments

@bonomat
Copy link
Collaborator

bonomat commented Jul 14, 2022

I thought I create a ticket for this. Just experienced on master (d7c332d) against testnet maker:

between verified all signatures and exchanged signed lock transaction 30 seconds have passed. Imho that's too long to ignore.

2022-07-14 08:09:11  INFO daemon::setup_contract_deprecated: Exchanged setup parameters
2022-07-14 08:09:13  INFO daemon::setup_contract_deprecated: Created CFD transactions
2022-07-14 08:09:14  INFO daemon::setup_contract_deprecated: Exchanged CFD transactions
2022-07-14 08:09:17  INFO daemon::setup_contract_deprecated: Verified all signatures
2022-07-14 08:09:26  INFO Handle Ping:Handle OpenSubstream < Single >:open_substream: xtra_libp2p::endpoint: return=("/ipfs/ping/1.0.0", Substream { inner: Negotiated { state: Completed { io: Stream { id: 7, connection: d578cfda } } } }) peer=PeerId("12D3KooWEsK2X8Tp24XtyWh7DM65VfwXtNH2cmfs2JsWmkmwKbV1") protocols=["/ipfs/ping/1.0.0"]
2022-07-14 08:09:56  INFO Handle Ping:Handle OpenSubstream < Single >:open_substream: xtra_libp2p::endpoint: return=("/ipfs/ping/1.0.0", Substream { inner: Negotiated { state: Completed { io: Stream { id: 9, connection: d578cfda } } } }) peer=PeerId("12D3KooWEsK2X8Tp24XtyWh7DM65VfwXtNH2cmfs2JsWmkmwKbV1") protocols=["/ipfs/ping/1.0.0"]
2022-07-14 08:09:59  INFO daemon::setup_contract_deprecated: Exchanged signed lock transaction
2022-07-14 08:10:00 DEBUG Handle SetupSucceeded: sqlite_db: Applying new events to CFD order_id=a5646688-436a-4dd0-afee-a966466704f5 aggregate=model::cfd::Cfd cfd_version=0 num_events=1

Your Taker ID: 477ea119e067298765f47e078873f44581a49f4fac0f7b6fde39cf96bbc49329
Your Peer ID: 12D3KooWBgvtt61jkGDYeN4fwzP6cLUbLA7BiZzK7iuRMf9E9Zrb

@Restioson
Copy link
Collaborator

Restioson commented Jul 14, 2022

Maybe we should instrument setup_contract_deprecated::new so that we can take a look inside - I'll open a PR shortly to do this

bors bot added a commit that referenced this issue Jul 17, 2022
2425: Instrument contract setup r=bonomat a=Restioson

Instruments the contract setup - related to #2413.

## TODO
- [x] Better name for "Do work on CETs"
- [ ] ~~Replace some log entries with semantic spans~~

Co-authored-by: Restioson <[email protected]>
@Restioson
Copy link
Collaborator

Restioson commented Jul 18, 2022

@bonomat gave an example trace in #2425:

example trace

To me, this looks like the maker is overloaded maybe? Could be related to #2414? If so, #2415 may have fixed this - can you still reproduce on master, @bonomat?

@bonomat
Copy link
Collaborator Author

bonomat commented Jul 19, 2022

It's still happening every now and then: This time it wasn't the lock transaction but Msg2

Jaeger-UI

@bonomat
Copy link
Collaborator Author

bonomat commented Jul 19, 2022

@klochowicz / @luckysori : any thoughts on this?

@bonomat
Copy link
Collaborator Author

bonomat commented Jul 19, 2022

This might be related: #2453

@luckysori
Copy link
Contributor

It's still happening every now and then: This time it wasn't the lock transaction but Msg2

What was the maker doing on the other side? Do we have traces for that?

@bonomat
Copy link
Collaborator Author

bonomat commented Jul 19, 2022

Unfortunately in this case not because of #2380

@bonomat
Copy link
Collaborator Author

bonomat commented Jul 25, 2022

We now know that this is because of the wallet sync time. There is nothing else we can do at the moment

@bonomat bonomat closed this as completed Jul 25, 2022
@klochowicz klochowicz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants