Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatically add app for review in testflight #2471

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat: automatically add app for review in testflight #2471

merged 2 commits into from
Apr 25, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Apr 25, 2024

@bonomat
Copy link
Contributor Author

bonomat commented Apr 25, 2024

Note that we do have a problem:
reviewing the app takes some time, if in the meantime the deployed coordinator changes with some breaking changes, the released reviewed app won't work.

Given we don't guarantee anything on regtest, I think we can live with this.

holzeis
holzeis approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although the App Store approval is a bit cumbersome to coordinate with a coordinator upgrade.

What do you think of only supporting users on our test vm with the apk?

.github/workflows/testflight-for-review.yml Outdated
bundle install
bundle info fastlane

- name: Put for beta testing app fro review
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Put for beta testing app fro review
- name: Put for beta testing app for review

@bonomat
Copy link
Contributor Author

bonomat commented Apr 25, 2024

What do you think of only supporting users on our test vm with the apk?

Given this action shouldn't cost us anything I would just run it as well and just don't guarantee anything. We don't have breaking changes too often 🤞.

@bonomat
feat: automatically put app for review
0e03d9a 
Unfortunately Apple only allows for having 1 build in review at a time. Hence, this patch adds a new CI action which runs every 24h hoping the former review has been finished.
If not, adding the build for review will fail.
@bonomat bonomat added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit fb17a16 Apr 25, 2024
22 checks passed
@bonomat bonomat deleted the feat/update-fastlane branch April 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holzeis holzeis holzeis approved these changes

@luckysori luckysori Awaiting requested review from luckysori

Assignees

@bonomat bonomat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonomat @holzeis