Skip to content

Commit

Permalink
feat: automatically put app for review
Browse files Browse the repository at this point in the history
Unfortunately Apple only allows for having 1 build in review at a time. Hence, this patch adds a new CI action which runs every 24h hoping the former review has been finished.
If not, adding the build for review will fail.
  • Loading branch information
bonomat committed Apr 25, 2024
1 parent 3a241f3 commit 0e03d9a
Show file tree
Hide file tree
Showing 3 changed files with 114 additions and 0 deletions.
69 changes: 69 additions & 0 deletions .github/workflows/testflight-for-review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
name: Daily Task

on:
schedule:
- cron: '0 0 * * *' # This will run the task every day at midnight UTC

jobs:
run_task:
name: Run Task
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: List installations Xcode version
run: sudo ls -1 /Applications | grep "Xcode"
- name: List used Xcode version
run: /usr/bin/xcodebuild -version
- name: Select different xcode version
run: sudo xcode-select -s '/Applications/Xcode_15.2.app/Contents/Developer'
- name: List used Xcode version
run: /usr/bin/xcodebuild -version

- uses: ./.github/actions/setup-fvm
with:
fvm_config: ./mobile/.fvmrc
working_dir: ./mobile

- name: Check cocoapods version
run: /usr/local/bin/pod --version
- name: Re-install cocoapods
run: sudo gem install cocoapods
- name: Check cocoapods version
run: /usr/local/bin/pod --version

- name: Install just
run: cargo install just --force

- name: Install fastlane
run: |
cd mobile/ios/fastlane
gem install bundler
bundle install
bundle info fastlane
- name: Put for beta testing app for review
env:
# secrets
FASTLANE_APPLE_ID: ${{ secrets.FASTLANE_APPLE_ID }}
FASTLANE_APP_STORE_CONNECT_TEAM_ID: ${{ secrets.FASTLANE_APP_STORE_CONNECT_TEAM_ID }}
FASTLANE_DEVELOPER_PORTAL_TEAM_ID: ${{ secrets.FASTLANE_DEVELOPER_PORTAL_TEAM_ID }}
FASTLANE_TEMP_KEYCHAIN_USER: ${{ secrets.FASTLANE_TEMP_KEYCHAIN_USER }}
FASTLANE_TEMP_KEYCHAIN_PASSWORD: ${{ secrets.FASTLANE_TEMP_KEYCHAIN_PASSWORD }}
FASTLANE_APPLE_ISSUER_ID: ${{ secrets.FASTLANE_APPLE_ISSUER_ID }}
FASTLANE_APPLE_KEY_ID: ${{ secrets.FASTLANE_APPLE_KEY_ID }}
FASTLANE_APPLE_KEY_CONTENT: ${{ secrets.FASTLANE_APPLE_KEY_CONTENT }}
FASTLANE_GIT_AUTHORIZATION: ${{ secrets.FASTLANE_GIT_AUTHORIZATION }}
MATCH_PASSWORD: ${{ secrets.FASTLANE_MATCH_PASSWORD }}
# regtest specific settings
FASTLANE_DEVELOPER_APP_ID: ${{ secrets.FASTLANE_DEVELOPER_REGTEST_APP_ID }}
FASTLANE_DEVELOPER_APP_IDENTIFIER: finance.get10101.app.test
FASTLANE_PROVISIONING_PROFILE_SPECIFIER: match AppStore finance.get10101.app.test
FASTLANE_APP_SCHEME: test
run: |
just publish-ios-to-group
- name: Print fastlane gym logs
if: always()
run: cat /Users/runner/Library/Logs/gym/10101*.log

3 changes: 3 additions & 0 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ publish-testflight:

build-ipa-no-codesign: (build-ipa "--no-codesign")

publish-ios-to-group:
cd mobile/ios/fastlane && bundle exec fastlane add_build_to_review --verbose

publish-testflight-fastlane:
cd mobile/ios/fastlane && bundle exec fastlane closed_beta --verbose

Expand Down
42 changes: 42 additions & 0 deletions mobile/ios/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,46 @@ platform :ios do
delete_temp_keychain(keychain_name)
end

lane :add_build_to_review do
keychain_name = TEMP_KEYCHAIN_USER
keychain_password = TEMP_KEYCHAIN_PASSWORD
ensure_temp_keychain(keychain_name, keychain_password)

api_key = app_store_connect_api_key(
key_id: APPLE_KEY_ID,
issuer_id: APPLE_ISSUER_ID,
key_content: APPLE_KEY_CONTENT,
duration: 1200,
in_house: false
)

build_number = sh("git", "rev-list", "HEAD", "--count")

cocoapods(
clean_install: true
)

match(
type: 'appstore',
app_identifier: "#{DEVELOPER_APP_IDENTIFIER}",
git_basic_authorization: Base64.strict_encode64(GIT_AUTHORIZATION),
readonly: true,
keychain_name: keychain_name,
keychain_password: keychain_password,
api_key: api_key
)

pilot(
apple_id: "#{DEVELOPER_APP_ID}",
app_identifier: "#{DEVELOPER_APP_IDENTIFIER}",
distribute_only: true,
build_number: "#{build_number}",
groups: ["external"],
changelog: "Nightly build, check master commit history for latest changes.",
)

delete_temp_keychain(keychain_name)

end

end

0 comments on commit 0e03d9a

Please sign in to comment.