Add TryFrom impls for JsonObject and JsonValue
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each GeoJson type, an `impl TryFrom<JsonObject>` and `impl
TryFrom<JsonValue>` is added, and the analagous `from_json_object` and
`from_json_value` functions are converted to use the new traits.
This makes it possible to simplify the instantiation of GeoJson types
like this:
```rust
let feature: Feature = json!({
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [102.0, 0.5]
},
"properties": null,
}).try_into().unwrap();
```
impls are added for:
* `GeoJson`
* `Geometry`
* `Feature`, and
* `FeatureCollection`.
API stability is maintained - the only change is that the
`from_json_object` methods take `JsonObject` instead of
`mut JsonObject`, but this should not break anything.
Tests are added where appropriate.
I'd changed this function for geometry objects, but not features/collections. This makes it consistent.
frewsxcv
approved these changes
Nov 16, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 16, 2019
120: Add `TryFrom` impls for JsonObject and JsonValue r=frewsxcv a=avandesa
For each GeoJson type, an `impl TryFrom<JsonObject>` and `impl
TryFrom<JsonValue>` is added, and the analagous `from_json_object` and
`from_json_value` functions are converted to use the new traits.
This makes it possible to simplify the instantiation of GeoJson types
like this:
```rust
let feature: Feature = json!({
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [102.0, 0.5]
},
"properties": null,
}).try_into().unwrap();
```
impls are added for:
* `GeoJson`
* `Geometry`
* `Feature`, and
* `FeatureCollection`.
API stability is maintained - the only change is that the
`from_json_object` methods take `JsonObject` instead of
`mut JsonObject`, but this should not break anything.
Tests are added where appropriate.
This commit expands on #119.
Co-authored-by: Alex van de Sandt <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each GeoJson type, an
impl TryFrom<JsonObject>andimpl TryFrom<JsonValue>is added, and the analagousfrom_json_objectandfrom_json_valuefunctions are converted to use the new traits.This makes it possible to simplify the instantiation of GeoJson types
like this:
impls are added for:
GeoJsonGeometryFeature, andFeatureCollection.API stability is maintained - the only change is that the
from_json_objectmethods takeJsonObjectinstead ofmut JsonObject, but this should not break anything.Tests are added where appropriate.
This commit expands on #119.