Add from_json_value for GeoJson enum
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There already exists `GeoJSON::from_json_object`, which converts a `serde_json::Map<String, serde_json::Value>` to a geojson instance. It would be convenient to be able to convert straight from a `serde_json::Value`, as this is what is constructed with the `json!` macro. This commit implements `GeoJson::from_json_value` as a thin wrapper around `from_json_object`.
|
Hi, thanks for the PR! If you'd like to add the |
yep yep, sounds good. feel free to open a new pr for those if you end up implementing them |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2019
119: Add `from_json_value` for `GeoJson` enum r=frewsxcv a=avandesa
There already exists `GeoJSON::from_json_object`, which converts a `serde_json::Map<String, serde_json::Value>` to a geojson instance.
The [`json!` macro][macro] from `serde_json` returns a `serde_json::Value`, which while similar to `Map<String, Value>`, is not the same, and there unfortunately is not `impl From<Value> for Map<_, _>`, just the other way around.
This PR implements `GeoJson::from_json_value` as a thin wrapper around `from_json_object`, which makes it convenient to use the `json!` macro to quickly create geojson objects from raw JSON in-source, instead of having to use the `parse` methods on string literals.
Minimal example use case:
```rust
let geojson = GeoJson::from_json_value(json!({
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [102.0, 0.5]
},
"properties": null,
}));
```
If you'd like, I can extend this PR to add similar functions for `Geometry`, `Feature`, and `FeatureCollection`, but I wanted to know if this would be a useful feature first.
Edit: Fixed typo in example.
[macro]: https://docs.serde.rs/serde_json/macro.json.html
Co-authored-by: Alex van de Sandt <[email protected]>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Nov 16, 2019
120: Add `TryFrom` impls for JsonObject and JsonValue r=frewsxcv a=avandesa
For each GeoJson type, an `impl TryFrom<JsonObject>` and `impl
TryFrom<JsonValue>` is added, and the analagous `from_json_object` and
`from_json_value` functions are converted to use the new traits.
This makes it possible to simplify the instantiation of GeoJson types
like this:
```rust
let feature: Feature = json!({
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [102.0, 0.5]
},
"properties": null,
}).try_into().unwrap();
```
impls are added for:
* `GeoJson`
* `Geometry`
* `Feature`, and
* `FeatureCollection`.
API stability is maintained - the only change is that the
`from_json_object` methods take `JsonObject` instead of
`mut JsonObject`, but this should not break anything.
Tests are added where appropriate.
This commit expands on #119.
Co-authored-by: Alex van de Sandt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already exists
GeoJSON::from_json_object, which converts aserde_json::Map<String, serde_json::Value>to a geojson instance.The
json!macro fromserde_jsonreturns aserde_json::Value, which while similar toMap<String, Value>, is not the same, and there unfortunately is notimpl From<Value> for Map<_, _>, just the other way around.This PR implements
GeoJson::from_json_valueas a thin wrapper aroundfrom_json_object, which makes it convenient to use thejson!macro to quickly create geojson objects from raw JSON in-source, instead of having to use theparsemethods on string literals.Minimal example use case:
If you'd like, I can extend this PR to add similar functions for
Geometry,Feature, andFeatureCollection, but I wanted to know if this would be a useful feature first.Edit: Fixed typo in example.