Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove root loggers (#923) #930

Merged
merged 1 commit into from
Jun 6, 2024
Merged

remove root loggers (#923) #930

merged 1 commit into from
Jun 6, 2024

Conversation

tomkralidis
Copy link
Member

Fixes #923

@tomkralidis
Copy link
Member Author

Test failures are unrelated.

cehbrecht
cehbrecht approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Cleans up the code :)

@tomkralidis tomkralidis merged commit 44e3ece into master Jun 6, 2024
0 of 8 checks passed
@tomkralidis tomkralidis deleted the issue-923 branch June 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cehbrecht cehbrecht cehbrecht approved these changes

@fmigneault fmigneault Awaiting requested review from fmigneault

@kalxas kalxas Awaiting requested review from kalxas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging module references inconsistent and unpracticable for configuration with other packages
2 participants
@tomkralidis @cehbrecht