Logging module references inconsistent and unpracticable for configuration with other packages

[fmigneault]

Some places use these references to obtain a logger:

OWSLib/owslib/util.py

Line 10 in 79909b4

import logging as log

OWSLib/owslib/wps.py

Lines 115 to 116 in 79909b4

	from owslib.util import (testXMLValue, testXMLAttribute, build_get_url, clean_ows_url, dump, getTypedValue,
	getNamespace, element_to_string, nspath, openURL, nspath_eval, log, Authentication)

OWSLib/owslib/wps.py

Line 308 in 79909b4

log.info(element_to_string(rootElement))

This causes the log.<level> function called to use the root logger.

On the other hand, the following use a specific logger (resulting in owslib.wps):

OWSLib/owslib/wps.py

Line 144 in 79909b4

LOGGER = logging.getLogger(__name__)

Because of this, there is no clean way to configure the logger all over owslib.
Even worst is that, when used inside another application, the root logger must often be silenced or raised to ERROR or WARNING level to avoid too much noise, since it can combine many other locations. This makes it unpractical to debug specific operations in owslib.

The logging references should be unified to all employ (at least) the owslib namespace instead of root.
A quick fix would be to replace import logging as log in owslib.util by the following:

import logging
log = logging.getLogger(__name__)

This way, any place "incorrectly" using the logging alias as log would at least transparently use a namespace'd logger instead.

Maybe there are other locations to patch, but I have not explored the full repository for other logging references.

[tomkralidis]

Ideally owslib.util.log should be removed and all code should use the LOGGER = logging.getLogger(__name__) approach. Would this work for you?

[fmigneault]

Yes. This is the best to have a non-root configurable logger that can be retrieved from anywhere.