Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to build/use libpbf2geojson on OpenBSD (fixes #280) #281

Open
wants to merge 3 commits into
base: dev-qgis3
Choose a base branch
from

Conversation

landryb
Copy link

@landryb landryb commented Mar 11, 2020

with the makefile bit, i get this:

[15:39] daytona:/tmp/Vector-Tiles-Reader-QGIS-Plugin/ $
    gmake openbsd
c++ -fPIC -std=c++11 -I/usr/local/include -s -Os -Ofast -O3 --shared -o ./ext-libs/pbf2geojson/pbf2geojson_openbsd_x86_64.so ./ext-libs/pbf2geojson/pbf2geojson.cpp

and i can use the native lib:

2020-03-11T15:17:19     WARNING    Vector Tiles Reader 3.2.2 (Python 3.7.6)
2020-03-11T15:18:05     WARNING    Loading native lib...
2020-03-11T15:18:05     WARNING    Native decoding supported!!! (OpenBSD, 64bit)

@lbartoletti maybe you want the same for FreeBSD ?

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #281 into dev-qgis3 will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##           dev-qgis3     #281      +/-   ##
=============================================
- Coverage      61.22%   61.15%   -0.08%     
=============================================
  Files             17       17              
  Lines           3384     3388       +4     
=============================================
  Hits            2072     2072              
- Misses          1312     1316       +4
Impacted Files Coverage Δ
plugin/util/mp_helper.py 67.88% <0%> (-2.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31ae86...08802e9. Read the comment docs.

Copy link

@lbartoletti lbartoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @landryb !
I added support for FreeBSD.

cc @rhurlin for information.

plugin/util/mp_helper.py Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants