Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for OpenBSD #280

Open
landryb opened this issue Mar 10, 2020 · 3 comments
Open

add support for OpenBSD #280

landryb opened this issue Mar 10, 2020 · 3 comments

Comments

@landryb
Copy link

landryb commented Mar 10, 2020

with a very small tweak to plugin/util/mp_helper.py:

adventurer:~/.local/share/QGIS/QGIS3/profiles/default/python/plugins/vector_tiles_reader/ $grep -B2 openbsd plugin/util/mp_helper.py 
    elif sys.platform.startswith("darwin"):
        lib = "pbf2geojson_osx_{}.so".format(bitness_string)
    elif sys.platform.startswith("openbsd"):
        lib = "pbf2geojson_openbsd6_{}.so".format(bitness_string)

and once i had manually built the pbf2geojson library (after installing the protozero & vtzero libraries)

adventurer:~/.local/share/QGIS/QGIS3/profiles/default/python/plugins/vector_tiles_reader/ext-libs/pbf2geojson/ $
  c++ -fPIC -std=c++11 -I/usr/local/include -s -Os -Ofast -O3 --shared -o pbf2geojson_openbsd6_x86_64.so pbf2geojson.cpp

i've been able to use the plugin with qgis 3.12 on OpenBSD:

2020-03-10T14:46:39     WARNING    Loading native lib...
2020-03-10T14:46:39     WARNING    Native decoding supported!!! (OpenBSD, 64bit)

tested working fine against the server provided at https://vectortiles.ign.fr/

dunno if you want a PR for the Makefile or the doc or...

@mnboos
Copy link
Collaborator

mnboos commented Mar 11, 2020

Awesome! Would you mind making a PR including the updated makefile as well as the compiled binaries?

@landryb
Copy link
Author

landryb commented Mar 11, 2020

the binaries wouldnt really make sense as OpenBSD has no promise of ABI stability, so right now a library build on my system has zero promise to work on another OpenBSD system in 2 months... but sure will make a PR with the makefile & loader bits.

landryb added a commit to landryb/Vector-Tiles-Reader-QGIS-Plugin that referenced this issue Mar 11, 2020
@mnboos
Copy link
Collaborator

mnboos commented Mar 11, 2020

Ok, if that's the case, then just updating the readme and makefile should be sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants