Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally scalars were always references onto external buffers. Then in #119 that was changed to try to better support bindings that can't have lifetime references. (E.g. neither python nor JS allow exports with lifetime references, because they can't verify when data will still be valid in those environments).
But over time it turned out that we really needed fully separate structs for these (e.g.
OwnedPoint
) that don't have their own lifetime parameters. This means that we never actually needed to makePoint
itself owned. We need to have separate structs anyways for the bindings.Having Cow on the scalars only serves to make coordinate access slower, because there's an indirection on access to the coordinate buffer.
Change list
Cow
wrappers on the internal buffers on scalars.Closes #472
Closes #449