Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cow on scalars #449

Closed
kylebarron opened this issue Jan 17, 2024 · 1 comment · Fixed by #720
Closed

Remove Cow on scalars #449

kylebarron opened this issue Jan 17, 2024 · 1 comment · Fixed by #720

Comments

@kylebarron
Copy link
Member

We need the Owned* scalars without lifetime generics anyways for the bindings, and so we don't need the overhead of having a Cow on each scalar part. Would be interesting to see if this improves benchmarks
@kylebarron
Copy link
Member Author

Also need to check #[allow(clippy::large_enum_variant)] on OwnedGeometry

@kylebarron kylebarron mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Cow around scalar buffers geoarrow/geoarrow-rs
1 participant
@kylebarron