Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS REVIEW] minor edits to the manuscript #82

Closed
3 tasks done
friedue opened this issue Sep 15, 2021 · 3 comments
Closed
3 tasks done

[JOSS REVIEW] minor edits to the manuscript #82

friedue opened this issue Sep 15, 2021 · 3 comments
Assignees

Comments

@friedue
Copy link

friedue commented Sep 15, 2021

Related to: openjournals/joss-reviews#3722

  • please extend the "statement of need" a bit, or rephrase it so that within the first sentence it is already obvious that bam-readcount is not so much just about counting reads, but primarily about collecting metrics that are particularly helpful in judging wether a specific variant call is reliable or not (or maybe that's not even the primary use-case, who knows! :) )
  • similarly, the conclusion should state a bit more clearly what precisely the role of bam-readcount is in the bespoke pipelines and the use cases that are mentioned there
  • lines 37 and 54 should have "its" instead of "it's"
@chrisamiller
Copy link
Collaborator

We've expanded the statement of need, and described the role of bam-readcount more thoroughly in the revised manuscript. Thanks for the typo corrections!

@friedue
Copy link
Author

friedue commented Dec 16, 2021

Great update to the text! The use-cases of the tool are very clearly described now, great job!

  • There's a typo on line 61, and there might be a letter missing in line 50, too ("disks?").

@chrisamiller
Copy link
Collaborator

Thanks - fixed and pushed!

@friedue friedue closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants