Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding LLR and MAPQ column to variants table #1019

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding LLR and MAPQ column to variants table #1019

wants to merge 1 commit into from

Conversation

saimukund20
Copy link
Collaborator

No description provided.

@chrisamiller
Copy link
Collaborator

Sai, once you confirm that this runs the full somatic exome test without breaking, then happy to approve!

@tmooney
Copy link
Member

tmooney commented Apr 1, 2021

Something to be aware of: every pipeline and subworkflow that calls this tool defines its own default for this inputs, which will override the one here. It's fine if we want to change the default when the tool is called directly, but I'm curious if any of the workflows should also have their defaults updated.

@chrisamiller
Copy link
Collaborator

Good point. Sai, you probably want to be changing the defaults on the somatic WGS and somatic exome workflows, not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saimukund20 @chrisamiller @tmooney