Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Rotate.js operations to ESM modules #285

Merged
merged 3 commits into from
Apr 6, 2018
Merged

Conversation

mattnotmitt
Copy link
Collaborator

@mattnotmitt mattnotmitt commented Apr 3, 2018

Content

Converted four operations:

  • ROT13
  • ROT47
  • Rotate left
  • Rotate right

Additionally created lib/Rotate.mjs, which contains shared default options & shared functions.

TODO

  • Write tests

Matt C and others added 3 commits April 3, 2018 22:50
4 Ops:
- ROT-13
- ROT-47
- Rotate left
- Rotate right
+ module containing common functions
@mattnotmitt mattnotmitt mentioned this pull request Apr 4, 2018
21 tasks
@n1474335 n1474335 merged commit af51090 into gchq:esm Apr 6, 2018
@n1474335
Copy link
Member

n1474335 commented Apr 6, 2018

Thanks very much for this, especially the new tests. I'll start working on a migration script soon, but I suspect it'll be more of a helper than a full solution. We're still going to have to go through every operation manually as there is a lot to change. It's a good opportunity to review and refactor everything though - never a bad idea!

My next focus is on the present() method and a good Node API. Once we have those nailed down we'll be looking to convert the rest of the operations, so anything you can help with will be greatly appreciated.

@mattnotmitt mattnotmitt deleted the esm branch April 27, 2018 15:42
@n1474335 n1474335 added this to the v8.0.0 milestone May 15, 2018
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
[FIX] Icon overlap and squeeze issues
Fixes gchq#283
Fixes gchq#285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants