-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ESM Conversion #284
Merged
WIP: ESM Conversion #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and some encoding types.
…ntities, URL encoding, escaped Unicode, and Quoted Printable encoding.
…anguages by default, to lower false positives and improve performance.
…various simple encodings like XOR or bit rotates.
…e' even though their output cannot be analysed
…s tooltips explaining the properties.
This operation calculates the great circle distance between two GPS co-ordinates, returning the value
…CyberChef into Dachande663-operation-haversine
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
[FIX] Improves item layout, fixes hover bug Fixes gchq#283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch covers the conversion of CyberChef to use ES6 modules.
Aims
src/core
to be rewritten in ESM format (.mjs, import, export, classes etc.)src/web
to be rewritten in ESM formatsrc/node
to be rewritten in ESM format so that it can be run usingnode --experimental-modules
without packing it with webpack (a packed CJS version will still be available for standard node)OperationConfig
and modules should be automatically generated at the build stage.val-loader
should be removed - it's an inelegant hack.Dish
data types should be added to support raw JSON and files.present()
method should be called on the final operation in a recipe to display it in a sensible manner for the web app.present()
method to display their output in a custom format.NodeJS API
We should aim to be able to export specific modules from the CyberChef package so that the 200+ operations can be used effectively in other projects.
An example (exact API still open to suggestions):
Issues
This should address #233.
Feedback
This represents a comprehensive architectural change so I'm very keen to get feedback. It will take a long time to port all current operations over to the new model, so we're starting off with just a small subset until we are completely happy that we've got it right. Please leave comments with ideas and recommendations.
@artemisbot @tlwr @d98762625
Remaining actions
newOperation
builder script @n1474335