Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Upstream Macro Migration : sdformat #1040

Merged
merged 6 commits into from
Jun 18, 2022
Merged

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 6, 2022
@chapulina chapulina self-requested a review June 6, 2022 23:54
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

@methylDragon methylDragon force-pushed the macro_migration branch 3 times, most recently from ca5e1dd to 75eab9e Compare June 8, 2022 22:30
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should just revert the tick-tock of a private function

src/ign.hh Outdated Show resolved Hide resolved
Migration.md Outdated Show resolved Hide resolved
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 15, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon enabled auto-merge (squash) June 18, 2022 01:26
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1040 (5790165) into main (d64d303) will not change coverage.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files         148      148           
  Lines       18393    18393           
=======================================
  Hits        15353    15353           
  Misses       3040     3040           
Impacted Files Coverage Δ
include/sdf/Exception.hh 100.00% <ø> (ø)
include/sdf/Filesystem.hh 100.00% <ø> (ø)
include/sdf/InterfaceElements.hh 75.00% <ø> (ø)
src/Camera.cc 87.78% <ø> (ø)
usd/src/cmd/sdf2usd.cc 37.93% <ø> (ø)
usd/src/usd_parser/USDWorld.cc 58.37% <ø> (ø)
usd/src/sdf_parser/Joint.cc 58.10% <40.00%> (ø)
usd/src/usd_parser/USDTransforms.cc 65.54% <75.00%> (ø)
python/src/sdf/pyBox.cc 66.66% <100.00%> (ø)
python/src/sdf/pyCapsule.cc 72.72% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64d303...5790165. Read the comment docs.

@chapulina chapulina disabled auto-merge June 18, 2022 02:01
@chapulina chapulina merged commit 39a3f87 into main Jun 18, 2022
@chapulina chapulina deleted the macro_migration branch June 18, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants