Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows Installation #214

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Add Windows Installation #214

merged 5 commits into from
Jan 21, 2021

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Jan 20, 2021 •
edited
Loading

Retargeting #207 to Citadel.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 20, 2021
@JShep1 JShep1 mentioned this pull request Jan 20, 2021
Closed
@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #214 (31fd360) into ign-transport8 (74b4719) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-transport8     #214   +/-   ##
===============================================
  Coverage           83.76%   83.76%           
===============================================
  Files                  51       51           
  Lines                5033     5033           
===============================================
  Hits                 4216     4216           
  Misses                817      817

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b4719...31fd360. Read the comment docs.

John Shepherd added 3 commits January 20, 2021 09:03
small nits
cf84724 
Signed-off-by: John Shepherd <[email protected]>
fix numbering
6a8c261 
Signed-off-by: John Shepherd <[email protected]>
move docs and testing to install
31fd360 
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from caguero as a code owner January 20, 2021 22:04
@JShep1 JShep1 requested a review from chapulina January 20, 2021 22:27
chapulina
chapulina approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@chapulina chapulina merged commit 1e7e8d9 into ign-transport8 Jan 21, 2021
@chapulina chapulina deleted the jshep1/mabelzhang/windows_install_transport8 branch January 21, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JShep1 @chapulina @mabelzhang