-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows installation via conda-forge #207
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-transport9 #207 +/- ##
==================================================
- Coverage 88.98% 88.98% -0.01%
==================================================
Files 49 47 -2
Lines 4668 4484 -184
==================================================
- Hits 4154 3990 -164
+ Misses 514 494 -20
Continue to review full report at Codecov.
|
I am not sure if the error is related to that, but conda-forge only ships Release libraries, and from the output of the example it seems that you are compiling the examples in Debug mode. Unfortunately, the C++ STL library that ships with MSVC has different ABIs in Release and in Debug, so if you compile the libraries in Release, you need to also compiles the examples in Release or RelWithDebInfo. On Linux/macOS the situation is different because both libstdcxx and libcxx are ABI compatible between Release and Debug builds. |
Then I think that the header https://github.com/ignitionrobotics/ign-transport/blob/ign-transport9/example/publisher_c.cc#L18 is Unix-only and can be probably dropped with no problems. |
Signed-off-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple feedback comments, but LGTM
cmake --build . # This currently does not succeed | ||
``` | ||
|
||
Try an example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the executables are placed within a Debug
folder, should we add --config Release
to the above build command?
cmake --build . --config Release | ||
``` | ||
|
||
1. Optionally, install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to run in admin mode to get the install to work, maybe a note here indicating that the user will need to do that too if they wish to install.
Closing this PR in favor of retargeting to Citadel. #214 |
Partially addresses gazebosim/docs#117
This replaces the old Windows installation instructions from Nov 2017, which installed dependencies by zip files and used
nmake
with VS 2013 on Windows 7 and 8. We have now decided to go with conda-forge, tested with VS 2019 on Windows 10.The current instructions built and installed, but I'm unsure about two things, which may be optional.
1. CMake warning about IFADDRS
I got a CMake warning about missing IFADDRS:
I tried installing ifaddr, but that didn't fix the warning after removing the build directory and rerunning cmake:
Seeing that
ifaddr
is for network interfaces, and this is transport, I don’t know if that warning can be ignored.What does it affect specifically, do we need to find it?
2. Errors building
example/
The old instructions built the examples and ran
responser
andrequester
.I wanted to keep that, but I wasn’t able to build the examples. I can run up to this:
Then when I ran
I got a lot of warnings and a few errors.