-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buoyancy improvements #818
Conversation
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still WIP, but I just did a quick pass
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
6ac7f4e
to
e864eba
Compare
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
…fail art in primary school. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! I pushed a new example and a small fix for it on 2abcabd. Now we just need to merge and release the ign-math
PR.
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
==========================================
+ Coverage 63.47% 63.56% +0.09%
==========================================
Files 241 241
Lines 19577 19675 +98
==========================================
+ Hits 12426 12507 +81
- Misses 7151 7168 +17
Continue to review full report at Codecov.
|
Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: William Lew <[email protected]>
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Depends on gazebosim/gz-math#219.
Summary
Often when simulating a maritime environment one may need to simulate both
surface and underwater vessels. This means the buoyancy plugin needs to
take into account two different fluids. One being water with a density of
1000kgm^-3 and another being air with a very light density of say 1kgm^-3.
An example for such a configuration may be found in the
graded_buoyancy.sdf
world.You should be able to see a sphere bobbing up and down undergoing simple
harmonic motion on the surface of the fluid (this is expected behaviour
as the SHM is usually damped by the hydrodynamic forces. See the hydro-
dynamics plugin for an example of how to use it). The key part of this is
The default density tag says that by default the world has a fluid density
of 1000kgm^-3. This essentially states that by default the world is filled
with dihydrogen monoxide (aka water). The
<density_change>
tagessentially establishes the fact that there is a nother fluid. The
<above_depth>
tag says that above z=0 there is another fluid with adifferent density. The density of that fluid is defined by the
<density>
tag. We will be simulating air with a fluid density of 1kgm^-3.
Test it
TODO
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge