Fix SDF plugin variables for MulticopterMotorModel #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bperseghetti
force-pushed
the
pr-mmm-sdf-fix
branch
2 times, most recently
from
ec77ecd
to
7c61f1b
Compare
|
FWIW, the parameter names were directly taken from https://github.com/ethz-asl/rotors_simulator/blob/master/rotors_gazebo_plugins/src/gazebo_motor_model.cpp to make it easier for users to transition from RotorS based models. |
ahcorde
approved these changes
May 8, 2023
azeey
requested changes
May 9, 2023
|
The plan is to make backward compatible changes in ign-gazebo6 and gz-sim7 without warnings (maybe with a todo to enable warnings) and then enable warnings in |
|
Removing beta from this as well per our conversation with Ben. |
Updated the Multicopter Motor Model plugin to use unified SDF variable formatting. Included a deprecation warning for users that the old variables will be removed in harmonic. Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
bperseghetti
force-pushed
the
pr-mmm-sdf-fix
branch
from
7c61f1b
to
c7ad1a8
Compare
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
|
@bperseghetti can you merge from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1980
Summary
Updated the MulticopterMotorModel plugin to use unified SDF variable
formatting. Included a deprecation warning for users that the old variables will be
removed in harmonic.
Checklist
codecheckpassed (See contributing)