Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playback_gui.config #1590

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Update playback_gui.config #1590

merged 1 commit into from
Jul 19, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 13, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Updated playaback_gui.config to use the individual GUI plugins instead of GzScene3D.

I left out the Shapes, Lights, Spawn, TransformControl, Screenshot, CopyPaste GUI plugins.

One advantage of switching to use the individual plugins (specifically MinimalScene and GzSceneManager) is that this allows visual plugins to load during playback.

To test:

  1. Remove existing playback_gui.confg file in ~/.ignition/gazebo/6/

  2. Launch shader_param.sdf world

    ign gazebo --record --record-path playback_test -v 4  ./src/ign-gazebo/examples/worlds/shader_param.sdf
    
  3. Use the Entity Tree plugin to select the deformable shape and use the Component Inspector to set its pose and move it around (This forces logging entity states)

  4. Close Gazebo and verify that a directory with state log exists in your current directory, i.e. playback_test/state.tlog

  5. Playback the log file:

    ign gazebo -v 4 --playback playback_test
    

Before this change, the waves would be white and the deformable sphere would be black in playback. After this change, the visual plugins should be loaded on the GUI side and these visuals should be properly colored and animated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from chapulina as a code owner July 13, 2022 01:14
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1590 (15a2b0f) into ign-gazebo6 (d6e69d0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 15a2b0f differs from pull request most recent head 7f2b925. Consider uploading reports for the commit 7f2b925 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1590   +/-   ##
============================================
  Coverage        64.02%   64.02%           
============================================
  Files              317      317           
  Lines            25649    25649           
============================================
  Hits             16422    16422           
  Misses            9227     9227           
Impacted Files Coverage Δ
src/Util.cc 92.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39bc25...7f2b925. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested! LGTM

@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) 🏯 fortress Ignition Fortress labels Jul 14, 2022
@chapulina chapulina merged commit 1bced4f into ign-gazebo6 Jul 19, 2022
@chapulina chapulina deleted the log_play_gui_cfg branch July 19, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants