Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Shared Lib Migration : gz-sim #1535

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Conversation

methylDragon
Copy link
Contributor

@chapulina chapulina added 🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. labels Jun 14, 2022
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from 606e354 to 6f5fa3e Compare June 14, 2022 18:30
@chapulina chapulina changed the base branch from main to macro_migration June 15, 2022 16:21
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retargeted this PR to the macro_migration branch (#1520 ) to reduce the diff, and the remaining diff seems to overlap with the CMake project name migration (#1527 )

@methylDragon methylDragon force-pushed the shared_lib_migration branch 3 times, most recently from 74391f6 to b538116 Compare June 16, 2022 21:12
Base automatically changed from macro_migration to main June 18, 2022 03:11
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from d24ebc6 to ae5e198 Compare June 18, 2022 06:24
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from 5d9ddb1 to 6d479fb Compare June 27, 2022 20:57
@methylDragon methylDragon marked this pull request as ready for review June 27, 2022 21:33
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1535 (5562898) into main (a3cbd8c) will decrease coverage by 0.05%.
The diff coverage is 99.31%.

@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
- Coverage   63.62%   63.57%   -0.06%     
==========================================
  Files         330      330              
  Lines       25787    25925     +138     
==========================================
+ Hits        16408    16481      +73     
- Misses       9379     9444      +65     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
include/gz/sim/SystemLoader.hh 100.00% <100.00%> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5336296...5562898. Read the comment docs.

@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from 19f7f7a to 7cc69d9 Compare June 29, 2022 17:00
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has some soft requirements on upstream PRs, but nothing breaking, so I think it's safe to merge once CI is happy.

@@ -90,12 +90,12 @@
<always_on>1</always_on>
<update_rate>30</update_rate>
<visualize>true</visualize>
<ignition:odometer>
<gz:odometer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -155,7 +155,7 @@
<ode>
<mu>1.0</mu>
<mu2>0.0</mu2>
<fdir1 ignition:expressed_in="chassis">1 -1 0</fdir1>
<fdir1 gz:expressed_in="chassis">1 -1 0</fdir1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@methylDragon methylDragon merged commit 0e314f9 into main Jul 7, 2022
@methylDragon methylDragon deleted the shared_lib_migration branch July 7, 2022 20:38
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants