-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz Shared Lib Migration : gz-sim #1535
Conversation
606e354
to
6f5fa3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
95440b2
to
1bac1c1
Compare
74391f6
to
b538116
Compare
d24ebc6
to
ae5e198
Compare
5d9ddb1
to
6d479fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1535 +/- ##
==========================================
- Coverage 63.62% 63.57% -0.06%
==========================================
Files 330 330
Lines 25787 25925 +138
==========================================
+ Hits 16408 16481 +73
- Misses 9379 9444 +65
Continue to review full report at Codecov.
|
19f7f7a
to
7cc69d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has some soft requirements on upstream PRs, but nothing breaking, so I think it's safe to merge once CI is happy.
@@ -90,12 +90,12 @@ | |||
<always_on>1</always_on> | |||
<update_rate>30</update_rate> | |||
<visualize>true</visualize> | |||
<ignition:odometer> | |||
<gz:odometer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires gazebosim/gz-sensors#235
@@ -155,7 +155,7 @@ | |||
<ode> | |||
<mu>1.0</mu> | |||
<mu2>0.0</mu2> | |||
<fdir1 ignition:expressed_in="chassis">1 -1 0</fdir1> | |||
<fdir1 gz:expressed_in="chassis">1 -1 0</fdir1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires gazebosim/gz-physics#356
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
2ffa719
to
fa0e365
Compare
Signed-off-by: methylDragon <[email protected]>
See: gazebo-tooling/release-tools#744