Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign to gz : Shared Libs and SDF attributes (systems and plugins) #744

Closed
Tracked by #698
methylDragon opened this issue Jun 14, 2022 · 2 comments
Closed
Tracked by #698
Labels
ign to gz Renaming Ignition to Gazebo.

Comments

@methylDragon
Copy link
Contributor

methylDragon commented Jun 14, 2022

Part of: #698

This tracks the migration effort for the gz -system and plugin shared libs.

This also FOLDS IN THE REMAINING SDF ATTRIBUTE CHANGES!!!

Notes

  • They should be merged in topological order
  • This should preferably be merged after the macro migration
  • ❗❗❗The CMake project name migration has to happen first, since this set of PRs assumes that has already happened (the project names affect certain CMake variables that feed into this, the PR assumes the gz variants for project names are used.)

Libs

Moved

  • gazebo.ign, gazebo_plugins.ign
  • gz-launch/plugins/: gazebo_factory, gazebo_server, gazebo_gui
    • GazeboGui, GazeboServer, GazeboFactory

Replaced

  • executable name='gazebo
  • ignition-launch-gazebo-factory
  • gazebo-server, gazebo-client
  • ...
@methylDragon
Copy link
Contributor Author

methylDragon commented Jun 16, 2022

Useful pattern to redirect loads instead of needing symlinks: gazebosim/gz-sim#1527

Here

    // Deprecated: accept ignition-gazebo-prefixed systems
    auto filename = _filename;
    if (filename.find("ignition-gazebo") != std::string::npos)
    {
      filename.replace(0, 15, "gz-sim");
      gzwarn << "Trying to load deprecated plugin [" << _filename
             << "]. Using [" << filename << "] instead." << std::endl;
    }

@methylDragon methylDragon changed the title ign to gz : Shared Libs (systems and plugins) (Pending CMake Project Name Migration) ign to gz : Shared Libs and SDF attributes (systems and plugins) Jun 27, 2022
@methylDragon
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Development

No branches or pull requests

2 participants