Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project() call to examples #1274

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Similar to

Summary

This is needed to silence CMake warnings like this:

33: CMake Warning (dev) in CMakeLists.txt:
33:   No project() command is present.  The top-level CMakeLists.txt file must
33:   contain a literal, direct call to the project() command.  Add a line of
33:   code such as
33: 
33:     project(ProjectName)
33: 
33:   near the top of the file, but after cmake_minimum_required().
33: 
33:   CMake is pretending there is a "project(Project)" command on the first
33:   line.
33: This warning is for project developers.  Use -Wno-dev to suppress it.

These warnings show up on Jenkins CI since we migrated from Bionic to Focal:

There are also CMP0072 warnings coming from the examples. I suspect that's coming from ign-gui because it currently links to ignition-rendering-ogre, but it shouldn't anymore after gazebosim/gz-gui#345.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1274 (5703854) into ign-gazebo3 (0d00cc1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3    #1274   +/-   ##
============================================
  Coverage        77.25%   77.25%           
============================================
  Files              227      227           
  Lines            13535    13535           
============================================
  Hits             10457    10457           
  Misses            3078     3078           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d00cc1...5703854. Read the comment docs.

@chapulina chapulina merged commit 700b369 into ign-gazebo3 Jan 7, 2022
@chapulina chapulina deleted the chapulina/3/project branch January 7, 2022 16:56
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants