Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sensor plugin to be able to visualize camera in plane_propeller_demo.sdf #1226

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 1, 2021

🦟 Bug fix

Summary

When I tried to visualize the camera from this example I was not able except if I include this plugin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1226 (b679022) into ign-gazebo6 (442fbfd) will increase coverage by 14.99%.
The diff coverage is n/a.

❗ Current head b679022 differs from pull request most recent head eb74560. Consider uploading reports for the commit eb74560 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo6    #1226       +/-   ##
================================================
+ Coverage        62.25%   77.25%   +14.99%     
================================================
  Files              275      227       -48     
  Lines            22710    13509     -9201     
================================================
- Hits             14138    10436     -3702     
+ Misses            8572     3073     -5499     
Impacted Files Coverage Δ
src/gui/plugins/shapes/Shapes.cc 31.25% <0.00%> (-21.39%) ⬇️
...ems/collada_world_exporter/ColladaWorldExporter.cc 78.64% <0.00%> (-16.18%) ⬇️
src/systems/buoyancy/Buoyancy.cc 75.28% <0.00%> (-7.74%) ⬇️
src/LevelManager.cc 86.36% <0.00%> (-2.78%) ⬇️
...nclude/ignition/gazebo/components/Serialization.hh 92.85% <0.00%> (-2.70%) ⬇️
include/ignition/gazebo/components/Factory.hh 96.05% <0.00%> (-2.65%) ⬇️
src/Conversions.cc 81.83% <0.00%> (-1.87%) ⬇️
src/Server.cc 84.33% <0.00%> (-1.81%) ⬇️
.../systems/triggered_publisher/TriggeredPublisher.cc 81.97% <0.00%> (-1.69%) ⬇️
src/systems/imu/Imu.cc 72.28% <0.00%> (-0.97%) ⬇️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442fbfd...eb74560. Read the comment docs.

@ahcorde ahcorde enabled auto-merge (squash) December 2, 2021 09:27
@ahcorde ahcorde merged commit f292777 into ign-gazebo6 Dec 2, 2021
@ahcorde ahcorde deleted the ahcorde/fix/plane_propeller branch December 2, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants