Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Commands via topic #1222

Merged
merged 13 commits into from
Dec 28, 2021

Conversation

WilliamLewww
Copy link
Contributor

🎉 Light Commands

Summary

Added a user command to control light properties:

ign topic -t /world/default/light_config -m Light -p "name: 'pointlight', diffuse: {r: 1.0, g: 0.0, b: 0.0, a: 1.0}, specular: {r: 1.0, g: 0.0, b: 0.0, a: 1.0}"

Added a light controller to control a specific light's properties:

ign topic -t /light/left_light_source/light_config -m Light -p "diffuse: {r: 1.0, g: 0.0, b: 0.0. a: 0.0}"

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 29, 2021
@WilliamLewww WilliamLewww reopened this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1222 (691384c) into ign-gazebo6 (0810a6b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 691384c differs from pull request most recent head 8b224bc. Consider uploading reports for the commit 8b224bc to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1222      +/-   ##
===============================================
+ Coverage        61.95%   61.97%   +0.01%     
===============================================
  Files              276      276              
  Lines            22991    23000       +9     
===============================================
+ Hits             14245    14254       +9     
  Misses            8746     8746              
Impacted Files Coverage Δ
src/systems/user_commands/UserCommands.cc 54.02% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0810a6b...8b224bc. Read the comment docs.

src/systems/light_controller/LightController.cc Outdated Show resolved Hide resolved
src/systems/light_controller/LightController.cc Outdated Show resolved Hide resolved
src/systems/light_controller/LightController.cc Outdated Show resolved Hide resolved
src/systems/light_controller/LightController.hh Outdated Show resolved Hide resolved
src/systems/user_commands/UserCommands.cc Show resolved Hide resolved
@WilliamLewww
Copy link
Contributor Author

Ignore the review request,

Trying to fix the DCO caused a bunch of new error. I'm currently trying to revert the changes.

@azeey azeey removed their request for review December 7, 2021 21:50
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments before merging

test/integration/user_commands.cc Outdated Show resolved Hide resolved
test/integration/user_commands.cc Outdated Show resolved Hide resolved
Signed-off-by: William Lew <[email protected]>
@chapulina chapulina changed the title Light Commands Light Commands via topic Dec 28, 2021
@chapulina chapulina enabled auto-merge (squash) December 28, 2021 22:03
@chapulina chapulina merged commit fe335f9 into gazebosim:ign-gazebo6 Dec 28, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants