-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Commands via topic #1222
Light Commands via topic #1222
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1222 +/- ##
===============================================
+ Coverage 61.95% 61.97% +0.01%
===============================================
Files 276 276
Lines 22991 23000 +9
===============================================
+ Hits 14245 14254 +9
Misses 8746 8746
Continue to review full report at Codecov.
|
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
507320f
to
17170cd
Compare
Ignore the review request, Trying to fix the DCO caused a bunch of new error. I'm currently trying to revert the changes. |
17170cd
to
45f878e
Compare
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We should add a test using the topic here:
Signed-off-by: William Lew <[email protected]>
f45e17c
to
691384c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments before merging
Signed-off-by: William Lew <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
🎉 Light Commands
Summary
Added a user command to control light properties:
Added a light controller to control a specific light's properties:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge