Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integers and floats on component inspector #1143

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Addresses part of #158

Summary

The Integer and Float QML files were not being compiled. This fixes that by adding them to the qrc file. It also fixes the looks of those types, adds unit support, and exercises them with a few components.

Screenshot from 2021-10-25 17-35-57
Screenshot from 2021-10-25 17-34-44

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Oct 26, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1143 (52362a7) into ign-gazebo3 (a42cac4) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1143      +/-   ##
===============================================
- Coverage        77.70%   77.45%   -0.25%     
===============================================
  Files              222      222              
  Lines            12716    12757      +41     
===============================================
  Hits              9881     9881              
- Misses            2835     2876      +41     
Impacted Files Coverage Δ
.../plugins/component_inspector/ComponentInspector.cc 6.50% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42cac4...52362a7. Read the comment docs.

@chapulina chapulina merged commit 3443ad4 into ign-gazebo3 Oct 27, 2021
@chapulina chapulina deleted the chapulina/3/inspector branch October 27, 2021 18:42
@chapulina chapulina mentioned this pull request Nov 16, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants