Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect more components #1090

Closed
wants to merge 3 commits into from
Closed

Inspect more components #1090

wants to merge 3 commits into from

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Part of #158

Summary

I'm adding some components to debug a project. Will open for review once I get a chance to clean this up.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Oct 6, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1090 (2674129) into ign-gazebo6 (15b664b) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

❗ Current head 2674129 differs from pull request most recent head df5fba4. Consider uploading reports for the commit df5fba4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1090      +/-   ##
===============================================
- Coverage        63.84%   63.73%   -0.12%     
===============================================
  Files              256      256              
  Lines            20077    20112      +35     
===============================================
  Hits             12818    12818              
- Misses            7259     7294      +35     
Impacted Files Coverage Δ
.../plugins/component_inspector/ComponentInspector.cc 4.89% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b664b...df5fba4. Read the comment docs.

@chapulina
Copy link
Contributor Author

Part of this went in with #1143 and the rest doesn't work well, so I'll close this.

@chapulina chapulina closed this Nov 16, 2021
@chapulina chapulina deleted the chapulina/6/inspector branch November 16, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant