Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky bounding box camera test #329

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 28, 2023

🦟 Bug fix

Fixes #328

Summary

Fixes flaky bounding box camera test due to timing / race condition. This PR fixes the test by making sure:

  1. we allow time for trigger msg to arrive to bounding box camera
  2. make sure msgs are received on the box topic (instead of image topic) which is what the tests is checking
  3. add mutex to protect the isTriggered variable.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #329 (7421a1d) into gz-sensors7 (0bab350) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7421a1d differs from pull request most recent head 651e1fb. Consider uploading reports for the commit 651e1fb to get more accurate results

@@             Coverage Diff              @@
##           gz-sensors7     #329   +/-   ##
============================================
  Coverage        69.97%   69.98%           
============================================
  Files               36       36           
  Lines             3920     3921    +1     
============================================
+ Hits              2743     2744    +1     
  Misses            1177     1177           
Impacted Files Coverage Δ
src/BoundingBoxCameraSensor.cc 61.02% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit 2d52be7 into gz-sensors7 Feb 28, 2023
@iche033 iche033 deleted the fix_triggered_bbcam_test branch February 28, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 triggered_boundingbox_camera integration test failing in gz-sensors7
3 participants