-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 -> 6 #327
3 -> 6 #327
Conversation
* Added Camera Info topic support for cameras --------- Signed-off-by: ahcorde <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Ian Chen <[email protected]>
* fix camera info test --------- Signed-off-by: Ian Chen <[email protected]>
Needs gazebosim/sdformat#1241 for green CI |
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #327 +/- ##
================================================
+ Coverage 73.76% 73.78% +0.02%
================================================
Files 34 34
Lines 3510 3513 +3
================================================
+ Hits 2589 2592 +3
Misses 921 921
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the required release is out. LGTM
@osrf-jenkins retest this please |
The test failure on macos seems to be consistent for the past few builds. |
the homebrew test failed because I think the sdformat 12.7.1 homebrew bottle didn't get released, looking into it |
homebrew is green! merging |
➡️ Forward port
Port ign-sensors3 to ign-sensors6
Branch comparison: ign-sensors6...ign-sensors3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)