Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 -> 6 #327

Merged
merged 3 commits into from
Mar 2, 2023
Merged

3 -> 6 #327

merged 3 commits into from
Mar 2, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 27, 2023

➡️ Forward port

Port ign-sensors3 to ign-sensors6

Branch comparison: ign-sensors6...ign-sensors3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 3 commits February 15, 2023 14:37
* Added Camera Info topic support for cameras

---------

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
* fix camera info test

---------

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 27, 2023
@iche033
Copy link
Contributor Author

iche033 commented Feb 27, 2023

Needs gazebosim/sdformat#1241 for green CI

@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label Feb 27, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #327 (cb1f50f) into ign-sensors6 (e03feb1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head cb1f50f differs from pull request most recent head fc7fa51. Consider uploading reports for the commit fc7fa51 to get more accurate results

@@               Coverage Diff                @@
##           ign-sensors6     #327      +/-   ##
================================================
+ Coverage         73.76%   73.78%   +0.02%     
================================================
  Files                34       34              
  Lines              3510     3513       +3     
================================================
+ Hits               2589     2592       +3     
  Misses              921      921              
Impacted Files Coverage Δ
src/CameraSensor.cc 77.63% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde removed the needs upstream release Blocked by a release of an upstream library label Mar 2, 2023
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the required release is out. LGTM

@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@mjcarroll
Copy link
Contributor

The test failure on macos seems to be consistent for the past few builds.

@iche033
Copy link
Contributor Author

iche033 commented Mar 2, 2023

the homebrew test failed because I think the sdformat 12.7.1 homebrew bottle didn't get released, looking into it

@iche033
Copy link
Contributor Author

iche033 commented Mar 2, 2023

homebrew is green! merging

@iche033 iche033 merged commit 187ee0e into ign-sensors6 Mar 2, 2023
@iche033 iche033 deleted the merge_3_6_20230224 branch March 2, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants