ign -> gz Provisional Finale: Source Migration : gz-plugin #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
chapulina
reviewed
Jul 14, 2022
chapulina
added
the
needs upstream release
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
ci_matching_branch/finale
branch
from
6c115c0
to
b91ad98
Compare
Rebased and resolved! (I was wondering why the suffix became |
Signed-off-by: methylDragon <[email protected]>
|
CI tests were coming back with linting errors. |
chapulina
removed
the
needs upstream release
chapulina
approved these changes
Jul 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 17 17
Lines 617 617
=======================================
Hits 613 613
Misses 4 4
Continue to review full report at Codecov.
|
scpeters
reviewed
Aug 17, 2022
| @@ -17,4 +17,4 @@ gz_build_tests( | |||
|
|
|||
|
|
|||
| add_subdirectory(include/gz/plugin) | |||
| install(DIRECTORY include/ignition DESTINATION ${IGN_INCLUDE_INSTALL_DIR_FULL}) | |||
There was a problem hiding this comment.
I think this broke installation of the include/ignition redirect headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#767