Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added utility functions to convert between msg::time and std::chrono time_point #81

Merged
merged 6 commits into from
Sep 10, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 26, 2020

This PR is related with this issue gazebosim/gz-common#61. The idea it's to deprecate the class common::Time in favor of std::chrono.

Related with

Added helpers functions to convert between

  • msg::Time to time_point
  • time_point to msg::Time
  • some tests too

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added enhancement New feature or request 🔮 dome Ignition Dome labels Aug 26, 2020
@ahcorde ahcorde requested a review from caguero as a code owner August 26, 2020 09:29
@ahcorde ahcorde self-assigned this Aug 26, 2020
src/Utility.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also be sure to update the required ign-math version to 6.5.0 on CMakeLists. That's the same for all libraries.

src/Utility_TEST.cc Outdated Show resolved Hide resolved
src/Utility.cc Outdated Show resolved Hide resolved
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed style updates and bumped the required ign-math version on 25e4f30, LGTM.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #81 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   85.69%   85.83%   +0.14%     
==========================================
  Files           7        7              
  Lines         797      805       +8     
==========================================
+ Hits          683      691       +8     
  Misses        114      114              
Impacted Files Coverage Δ
src/Utility.cc 83.70% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268ddcc...25e4f30. Read the comment docs.

@chapulina
Copy link
Contributor

@osrf-jenkins run tests now that the Jenkins server has been restarted

@chapulina
Copy link
Contributor

Queued a new homebrew build now that ign-math 6.5.0 is in: https://build.osrfoundation.org/job/ignition_msgs-ci-pr_any-homebrew-amd64/

@chapulina chapulina merged commit c3300f0 into master Sep 10, 2020
@chapulina chapulina deleted the ahcorde/time/utilities branch September 10, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants