-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added utility functions to convert between msg::time and std::chrono time_point #81
Conversation
…time_point Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also be sure to update the required ign-math
version to 6.5.0 on CMakeLists
. That's the same for all libraries.
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed style updates and bumped the required ign-math
version on 25e4f30, LGTM.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 85.69% 85.83% +0.14%
==========================================
Files 7 7
Lines 797 805 +8
==========================================
+ Hits 683 691 +8
Misses 114 114
Continue to review full report at Codecov.
|
@osrf-jenkins run tests now that the Jenkins server has been restarted |
Queued a new homebrew build now that |
This PR is related with this issue gazebosim/gz-common#61. The idea it's to deprecate the class
common::Time
in favor ofstd::chrono
.Related with
Added helpers functions to convert between
Signed-off-by: ahcorde [email protected]