-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow topic and service to construct messages from description files #428
Conversation
The current implementation allows for additional messages to be read from these files, it was just not properly configured for the files to be accessible. Signed-off-by: Michael Carroll <[email protected]>
@osrf-jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you testing it? Is this example easily backportable?
I can add a test. Since this is already targeting gz-msgs9 (garden), I don't think there is a reason to backport it any further? |
I mean the example from |
Signed-off-by: Michael Carroll <[email protected]>
Added an INTEGRATION_descriptors test with a few more descriptors configurations to exercise this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-msgs9 #428 +/- ##
============================================
+ Coverage 95.57% 96.16% +0.59%
============================================
Files 10 10
Lines 1062 1069 +7
============================================
+ Hits 1015 1028 +13
+ Misses 47 41 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Carroll <[email protected]>
@osrf-jenkins retest this please |
🦟 Bug fix
The current implementation allows for additional messages to be read from these files, it was just not properly configured for the files to be accessible.
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.