Pose3: deprecate + operator in favor of * #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 68 68
Lines 6314 6314
=======================================
Hits 6297 6297
Misses 17 17
Continue to review full report at Codecov.
|
azeey
reviewed
Mar 2, 2022
| EXPECT_TRUE(pose == | ||
| math::Pose3d(5.74534, 7.01053, 8.62899, 0.675732, 0.535753, 1.01174)); | ||
|
|
||
| pose += pose; | ||
| pose *= pose; |
I wanted to address them separately, so I'll make a follow-up pull request about |
scpeters
force-pushed
the
pose_deprecate_addition
branch
from
d9a6d4a
to
35bda79
Compare
The * operator matches the behavior of multiplying transform matrices, so it should be preferred over the addition operator, which is confusing. Part of gazebosim#60. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
pose_deprecate_addition
branch
from
35bda79
to
06fafd9
Compare
|
I think this is ready for review as downstream packages have already been fixed to use |
azeey
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #60.
Summary
The
*operator matches the behavior of multiplying transform matrices, so it should be preferred over the addition operator, which is confusing. This will be a draft PR until the deprecation warnings have been fixed in downstream packages.Test it
Run the
UNIT_Pose_TEST, which uses the*operator instead of+.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.