-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SWIG interfaces from python to ruby #354
Conversation
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
…itionrobotics/ign-math into ahcorde/pybind11/signalstats
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #354 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6380 6380
==========================================
Hits 6358 6358
Misses 22 22 Continue to review full report at Codecov.
|
…to ahcorde/pybind11/vector3Stats
…nitionrobotics/ign-math into ahcorde/pybind11/vector3Stats
…nto ahcorde/pybind11/removeSWIG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're just missing the SphericalCoordinates
migration to pybind11.
Adding a cross-reference link to the issue about enabling these SWIG files:
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ That was an impressive number of PRs merged in a short time 😄
I think we can dismiss the ABI checker, since we're not promising ABI stability of the python shared libraries. |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR removes SWIG python interfaces
Require:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.