-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SignalStats pybind11 interface #343
Conversation
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are linter warnings:
/github/workspace/src/python_pybind11/src/SignalStats.cc:64: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/python_pybind11/src/SignalStats.cc:64: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
/github/workspace/src/python_pybind11/src/SignalStats.cc:483: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 3
And test failures:
AttributeError: 'ignition.math.SignalMap' object has no attribute 'keys'
Signed-off-by: Alejandro Hernández <[email protected]>
…itionrobotics/ign-math into ahcorde/pybind11/signalstats
Codecov Report
@@ Coverage Diff @@
## ign-math6 #343 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6380 6380
==========================================
Hits 6358 6358
Misses 22 22 Continue to review full report at Codecov.
|
This still has test failures:
|
Signed-off-by: Alejandro Hernández <[email protected]>
@osrf-jenkins run tests please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR creates a SignalStats Pybind11 interface
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.