Defer regex construction to avoid static initialization #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
commented
Nov 23, 2021
7 tasks
Signed-off-by: Jeremy Nimmer <[email protected]>
jwnimmer-tri
force-pushed
the
fiasco-regex
branch
from
6647205
to
d0f8632
Compare
ahcorde
approved these changes
Nov 24, 2021
|
I'm not sure if I'm reading it correctly, but the windows CI failure seems like an infrastructure flake and not a problem with the PR? |
Yup, I just retriggered it |
mjcarroll
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Mitigates a portion of #269. Builds on #288 that moved the function to the cc file.
Summary
Checklist
Added tests (N/A)Updated documentation (as needed)Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge