Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evict large function definitions from the Helpers.hh header file #288

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Nov 23, 2021

🦟 Bug fix

Summary

Evict large function definitions from the Helpers.hh header file, per Google Style Guide.

This is a prerequistite for fixing the static storage duration of the std::regex used by the duration parser, towards the goal of #269.

Checklist

  • Signed all commits for DCO
  • Added tests (N/A)
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing) -- no new errors; the 9 errors on the main branch are also reported on this PR.
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jwnimmer-tri
Copy link
Contributor Author

In other projects, sometimes when I move code from hh to cc files, I'll add Co-authored-by lines to the commit message to reflect the original (header file) authorship of the moved lines back into the cc file. Let me know if you'd like me to do that here.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwnimmer-tri
Copy link
Contributor Author

Windows is fixed as of the latest push. I'd missed the IGNITION_MATH_VISIBLE the first time around.

@mjcarroll
Copy link
Contributor

Let me know if you'd like me to do that here.

I don't think it's necessary here.

@mjcarroll mjcarroll enabled auto-merge (squash) November 23, 2021 20:40
@mjcarroll mjcarroll dismissed ahcorde’s stale review November 23, 2021 20:40

windows ci is fixed

@mjcarroll mjcarroll merged commit 797f67f into gazebosim:main Nov 23, 2021
@jwnimmer-tri jwnimmer-tri deleted the helpers-no-inline branch November 23, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants