Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions CI #139

Merged
merged 24 commits into from
Aug 3, 2020
Merged

Update actions CI #139

merged 24 commits into from
Aug 3, 2020

Conversation

chapulina
Copy link
Contributor

Update actions CI to work with gazebo-tooling/action-gz-ci#13.

Also, show the collapsibles from gazebo-tooling/action-gz-ci#14 in action.

@chapulina
Update actions CI
246aac6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Jul 20, 2020
@chapulina chapulina requested a review from scpeters as a code owner July 20, 2020 21:23
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jul 20, 2020
@chapulina
Use master
c0e2bc2 
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #139 into ign-math6 will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-math6     #139      +/-   ##
=============================================
- Coverage      99.50%   99.30%   -0.21%     
=============================================
  Files             59       59              
  Lines           5662     5751      +89     
=============================================
+ Hits            5634     5711      +77     
- Misses            28       40      +12
Impacted Files Coverage Δ
include/ignition/math/MassMatrix3.hh 99.40% <ø> (-0.01%) ⬇️
src/RollingMean.cc 100.00% <ø> (ø)
include/ignition/math/Filter.hh 100.00% <100.00%> (ø)
include/ignition/math/Pose3.hh 100.00% <100.00%> (ø)
include/ignition/math/Vector2.hh 100.00% <100.00%> (ø)
include/ignition/math/Vector4.hh 95.10% <100.00%> (-4.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c513cde...d827244. Read the comment docs.

@chapulina chapulina mentioned this pull request Jul 21, 2020
Merged
@chapulina chapulina mentioned this pull request Jul 27, 2020
Merged
@chapulina chapulina mentioned this pull request Jul 29, 2020
Merged
@chapulina
Focal
cfa61e8 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
push is enough
aa6eb32 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ci master
78b665a 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Jul 30, 2020
Merged
@chapulina
satisfy cppcheck when possible
508d571 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mjcarroll July 31, 2020 20:00
@chapulina chapulina mentioned this pull request Aug 1, 2020
Merged
mjcarroll
mjcarroll approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@chapulina chapulina merged commit c43f478 into ign-math6 Aug 3, 2020
@chapulina chapulina deleted the chapulina/actions_groups branch August 3, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome tests Broken or missing tests / testing infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @mjcarroll