Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common widget for pose #424
Add common widget for pose #424
Changes from all commits
08c2256
1ecdadd
91c1df7
b7dd51d
9cbd9e3
deece4c
9bb7e6a
0dc0861
94341ec
20eb9d9
ee26c69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to set up
IgnHelpers.qml
in a way that we don't have to instantiate a dummy component and just be able to call the functions (e.g.,IgnHelpers.getDecimals(...)
)?This is out of scope for this PR but if it is possible, after we merge this, this could potentially be a next task for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well. This is doable but we need to make sure every qml using this common widget must also include
IgnHelpers.qml
as well. Do we want to do this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this would be a nice change. This PR is just following the weird pattern that I started with
IgnHelpers
a while back, so we don't need to block on it.I think there may be ways to work around this, either with a singleton or a javascript file.