Add common widget for pose

[AzulRadio]

• Part of Provide reusable QML components with common widgets #310

New feature

Summary

Add the common widget for Pose

Test it

Can be tested with branch azulradio/common_widget_pose in repo gz-sim

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #424 (ee26c69) into ign-gui3 (27afc95) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui3     #424   +/-   ##
=========================================
  Coverage     66.12%   66.12%           
=========================================
  Files            29       29           
  Lines          3218     3218           
=========================================
  Hits           2128     2128           
  Misses         1090     1090           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27afc95...ee26c69. Read the comment docs.

[jennuine]

Looks good, left some comments.

There's a couple of bugs I've encountered (not sure if they are correlated). When you first expand the pose submenu in the component inspector, you're able to update the pose fine and when the pose submenu stays open when you click on another object. If you keep selecting other objects, eventually the pose submenu closes and when you re-open it you're no longer able to update the pose. See gif below. Also, notice the sphere will eventually move when selected from the entity tree.

Ignore previous statement, it wasn't reproducible by others

[jennuine]

Looking good! Just left some reminders regarding what we discussed in our video call

[jennuine]

Left some minor comments but looks good, thanks for iterating!

[jennuine]

Is it possible to set up IgnHelpers.qml in a way that we don't have to instantiate a dummy component and just be able to call the functions (e.g., IgnHelpers.getDecimals(...))?

This is out of scope for this PR but if it is possible, after we merge this, this could potentially be a next task for you.

[AzulRadio]

Well. This is doable but we need to make sure every qml using this common widget must also include IgnHelpers.qml as well. Do we want to do this?

[chapulina]

Agreed that this would be a nice change. This PR is just following the weird pattern that I started with IgnHelpers a while back, so we don't need to block on it.

we need to make sure every qml using this common widget must also include IgnHelpers.qml as well.

I think there may be ways to work around this, either with a singleton or a javascript file.

[jennuine]

Can you specify "its parameters"? Do you mean, from the property var *Item variables?

When you say, "User should read spinbox...", is that when readOnly is true? If this is the case, it would be good to explicitly state that eg., "When true, users should read spinbox..."

[AzulRadio]

"its parameters" refers to the parameters of this signal.

I think you mean when readOnly is false. Here, I also want to stress that when readOnly is "true", this signal is not used (so should not be used by users, too). Would you like to check if my latest commit is clear on these?

[chapulina]

Oh I was just leaving a review and saw that the PR was merged. @AzulRadio , do you mind opening a new PR addressing the comments that you agree with? Thanks!