-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshot plugin #170
Screenshot plugin #170
Conversation
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #170 +/- ##
============================================
- Coverage 60.55% 59.23% -1.33%
============================================
Files 21 23 +2
Lines 2624 2730 +106
============================================
+ Hits 1589 1617 +28
- Misses 1035 1113 +78
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Some suggestions below.
Also, do you mind adding some basic tests? Maybe just instantiating the plugin, requesting the service, and checking that a file was created?
* Suggestions to #170 Signed-off-by: Louise Poubel <[email protected]> * Debug message with camera name Signed-off-by: Louise Poubel <[email protected]> * fix path Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Here's a fix for the swapped colors: gazebosim/gz-common#162 |
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Added a simple test that only instantiates plugin e8c3cd2. The code that loads the Scene3D plugin and requests the service is commented out because currently unable to load Scene3D from another plugin. |
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
I pushed c33970b directly to this branch so we suppress the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating, works great!
Closes #95
This plugin takes screenshots similar to Gazebo-classic by clicking the camera icon. The plugin uses a screenshot service that saves an image of the current 3D scene from the user camera. The default directory of saved screenshots is
~/.ignition/gui/pictures
but users can change the directory by selecting the folder icon.This can be used along with ign-gazebo's screenshot service in gazebosim/gz-sim#588EDIT: depends on gazebosim/gz-sim#598